Add blocked state as SyncJobStatus. #2550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJ1998
reviewed
Jun 20, 2024
| @@ -104,12 +105,49 @@ class SyncInstrumentedTest { | |||
| assertThat(states.last()).isInstanceOf(CurrentSyncJobStatus.Succeeded::class.java) | |||
| } | |||
|
|
|||
| @Test | |||
| fun oneTime_worker_nextExecutionAfterSucceeded() { | |||
There was a problem hiding this comment.
What is this function trying to test ?
Maybe name the function in this format <context>_<action>_<result>. For example newPatient_insert_recordIsAddedToDatabase
There was a problem hiding this comment.
Lets review #2511 first, its parent pr.
|
precondition : review and merge #2511 |
…oogle#2573) Bumps the pip group with 1 update in the / directory: [urllib3](https://github.com/urllib3/urllib3). Updates `urllib3` from 2.2.1 to 2.2.2 - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update link to GitHub Packages * update link to GitHub Packages * Update docs/use/Snapshots.md Co-authored-by: Jing Tang <jingtang@google.com> --------- Co-authored-by: Jing Tang <jingtang@google.com>
…2134) * Configurable bottom navigation to be part of page scroll * Shared layout for bottom navigation items, for scroll and sticky * Use separate recyclerview for bottom navigation items * Fix build errors * Remove unnecessary disabled state * Delete the unnecessary navigation recycler view * Simplify unnecessary .apply --------- Co-authored-by: Francis Odhiambo <4540684+f-odhiambo@users.noreply.github.com> Co-authored-by: Jing Tang <jingtang@google.com>
* Support Custom Search Parameter in x-fhir-query * Instead of exposing whole FhirEngineConfiguration use SearchParamDefinitionsProvider * Added kdoc for newly created function
* update readme according to review comments * remove extra sub-header * remove extra * recommend to try catalog app in action * add catalog app link * improve documentation * Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md Co-authored-by: Jing Tang <jingtang@google.com> * Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md Co-authored-by: Jing Tang <jingtang@google.com> * Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md Co-authored-by: Jing Tang <jingtang@google.com> * Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md Co-authored-by: Jing Tang <jingtang@google.com> * Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md Co-authored-by: Jing Tang <jingtang@google.com> * Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md Co-authored-by: Jing Tang <jingtang@google.com> * Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md Co-authored-by: Jing Tang <jingtang@google.com> --------- Co-authored-by: Jing Tang <jingtang@google.com>
* Deprecate old plan generation APIs * Rename params
* Migrate AndroidX dependencies to the version catalog * Update Dependencies.kt
…gle#2589) * Bind to bottomNavContainerFrame only if bottomNavItems not empty * Add tests for setShowNavigationInDefaultLongScroll
* delete operation on updated answers. * Remove deep copy for answers. * unit test. * unit test. * link the issue to added test. --------- Co-authored-by: Santosh Pingle <spingle@google.com>
Co-authored-by: Santosh Pingle <spingle@google.com>
* Update enablement evaluator * Add test case for calculating enable when with new repeated group * Add tests for shouldHaveNestedItemsUnderAnswers
google#2511) * currentSyncJobStatus when sync state in workmanager is null. * unit tests. * update kdoc * address review comments. --------- Co-authored-by: Santosh Pingle <spingle@google.com>
Bumps the pip group with 1 update in the / directory: [certifi](https://github.com/certifi/python-certifi). Updates `certifi` from 2024.2.2 to 2024.7.4 - [Commits](certifi/python-certifi@2024.02.02...2024.07.04) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
After merging master it shows individual commit in the log, as result it shows as many as files as changed files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2538
Description
Added Blobked state to SyncJobStatus
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.