Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to generate TokenIndex for fhirType code #693

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

aditya-07
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes : NO issue created

Description
Searchable fields like Patient.gender were not getting indexed in the database.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #693 (39fe9a5) into master (2ccda9b) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

❗ Current head 39fe9a5 differs from pull request most recent head 9a1b460. Consider uploading reports for the commit 9a1b460 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #693      +/-   ##
============================================
- Coverage     58.02%   57.78%   -0.25%     
  Complexity      194      194              
============================================
  Files            45       45              
  Lines           891      893       +2     
  Branches        122      124       +2     
============================================
- Hits            517      516       -1     
  Misses          295      295              
- Partials         79       82       +3     
Impacted Files Coverage Δ
...a/com/google/android/fhir/index/ResourceIndexer.kt 46.93% <0.00%> (-0.65%) ⬇️
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt 35.55% <0.00%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ccda9b...9a1b460. Read the comment docs.

@aditya-07 aditya-07 merged commit 2bed136 into master Aug 10, 2021
@aditya-07 aditya-07 deleted the ak/resource-index-codetype branch August 10, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants