Remove redundant limit on number of search results #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bausmeier
requested review from
aditya-07,
deepankarb,
jingtang10,
kevinmost,
pankajkatoch,
stevenckngaa and
yigit
as code owners
|
@trevorgowing I can't request a review on the PR, but please will you take a look and confirm that this resolves the issue for you? |
bausmeier
force-pushed
the
ba/gh-788-fix-npe
branch
from
b50f86f
to
777bfdd
Compare
|
@bausmeier Working for me. Nice one. |
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
============================================
- Coverage 35.18% 35.16% -0.03%
+ Complexity 315 314 -1
============================================
Files 115 115
Lines 4360 4360
Branches 841 841
============================================
- Hits 1534 1533 -1
Misses 2496 2496
- Partials 330 331 +1
Continue to review full report at Codecov.
|
jingtang10
approved these changes
Sep 30, 2021
|
please feel free to merge |
Accessing the value of `patientCount` using the not-null assertion operator was resulting in a Null Pointer Exception if the count operation had not yet completed. Limiting the number of search results based on the count was not necessary anyway since the set of filters used for the search was narrower than those used for the count which meant that the count would always be greater than or equal to the number of search results.
bausmeier
force-pushed
the
ba/gh-788-fix-npe
branch
from
777bfdd
to
ca04471
Compare
|
@jingtang10 Thanks, I've rebased against master so that the branch is up to date to pass the branch protection, but I don't have write access to the repo to be able to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788.
Description
Remove redundant limit on number of search results
Type
Bug fix.
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally