Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release AutoFactory 1.1.0 #1628

Closed
eamonnmcmanus opened this issue Nov 5, 2023 · 1 comment
Closed

Release AutoFactory 1.1.0 #1628

eamonnmcmanus opened this issue Nov 5, 2023 · 1 comment

Comments

@eamonnmcmanus
Copy link
Member

We have not released a new version of AutoFactory since 2021-04-21. That means a number of important changes are unavailable to open-source users. The following would be the generated release notes for a version released now:

  • AutoFactory now recognizes and generates both javax.inject and jakarta.inject. If jakarta.inject is on the classpath then it will be used, and otherwise javax.inject. A new compiler option -Acom.google.auto.factory.InjectApi can be set to either javax or jakarta to force the use of one or the other. (67772b2)
  • There is now a way to add annotations to generated AutoFactory classes. See the javadoc for @AutoFactory.AnnotationsToApply. (b2a1c08)
  • The exception message for a null value now indicates not only which number argument it is but also how many arguments there are in total. This may lead to a small increase in code size. (ab6c7bf)
  • AutoFactory now correctly handles the case where a parameter annotation has @Target with both PARAMETER and TYPE_USE. (9d455fa)
  • When a requested supertype of the generated factory class has a type parameter, the generated class now always has the same parameter. (206b673)
  • Add better error message when detecting duplicate parameters (59ec5e6)

The first two are of particular interest.

We need some work on the pom.xml. Attempting to release currently hits several failures in Sonatype's "Central Sync Requirement" category:

  • javadoc-staging: Missing: no javadoc jar found in folder '/com/google/auto/factory/auto-factory/1.1.0'
  • sources-staging: Missing: no sources jar found in folder '/com/google/auto/factory/auto-factory/1.1.0'
  • pom-staging: Invalid POM: /com/google/auto/factory/auto-factory/1.1.0/auto-factory-1.1.0.pom: Developer information missing
  • signature-staging: Missing Signature: '/com/google/auto/factory/auto-factory/1.1.0/auto-factory-1.1.0.jar.asc' does not exist for 'auto-factory-1.1.0.jar'.
  • signature-staging: Missing Signature: '/com/google/auto/factory/auto-factory/1.1.0/auto-factory-1.1.0.pom.asc' does not exist for 'auto-factory-1.1.0.pom'.
@eamonnmcmanus eamonnmcmanus self-assigned this Nov 5, 2023
copybara-service bot pushed a commit that referenced this issue Nov 13, 2023
This is one of the release requirements mentioned in #1628.

RELNOTES=n/a
PiperOrigin-RevId: 582075408
copybara-service bot pushed a commit that referenced this issue Nov 13, 2023
This is one of the release requirements mentioned in #1628.

RELNOTES=n/a
PiperOrigin-RevId: 582099482
copybara-service bot pushed a commit that referenced this issue Nov 19, 2023
This makes progress towards fixing #1628, about being able to release AutoFactory.

RELNOTES=n/a
PiperOrigin-RevId: 583842609
copybara-service bot pushed a commit that referenced this issue Nov 19, 2023
This makes progress towards fixing #1628, about being able to release AutoFactory.

RELNOTES=n/a
PiperOrigin-RevId: 583842609
copybara-service bot pushed a commit that referenced this issue Nov 20, 2023
This makes progress towards fixing #1628, about being able to release AutoFactory.

RELNOTES=n/a
PiperOrigin-RevId: 583842609
copybara-service bot pushed a commit that referenced this issue Nov 20, 2023
This makes progress towards fixing #1628, about being able to release AutoFactory.

RELNOTES=n/a
PiperOrigin-RevId: 583990205
@eamonnmcmanus
Copy link
Member Author

1.1.0 has now been released to Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant