Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE on missing Service? #1190

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.testing.compile.Compiler;
import com.google.testing.compile.JavaFileObjects;
import javax.tools.StandardLocation;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand Down Expand Up @@ -144,4 +145,21 @@ public void nestedGenericWithVerifyOptionAndSuppressWarnings() {
.contentsAsUtf8String()
.isEqualTo("test.EnclosingGeneric$GenericServiceProvider\n");
}

@Test @Ignore
public void missing() {
Compilation compilation =
Compiler.javac()
.withProcessors(new AutoServiceProcessor())
.withOptions("-Averify=true")
.compile(
JavaFileObjects.forResource("test/GenericServiceProviderWithMissingServiceClass.java")
);
assertThat(compilation).succeededWithoutWarnings();
assertThat(compilation)
.generatedFile(StandardLocation.CLASS_OUTPUT, "META-INF/services/test.GenericService")
.contentsAsUtf8String()
.isEqualTo("test.EnclosingGeneric$GenericServiceProvider\n");
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package test;

import com.google.auto.service.AutoService;

/**
* An implementation of a service with a type parameter, which by default will produce a warning
* if you compile with {@code -Averify=true}.
*/
@AutoService(MissingServiceClass.class)
public class GenericServiceProviderWithMissingServiceClass<T> implements MissingServiceClass<T> {}