Solve anonymous namespaces and other problems #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has two fixes (which started off related but then ceased to be): * If we ignore a template for some reason, we now no longer generate a concrete type for usages thereof. This may be more conservative than we need. It may be that some reasons why templates are ignored do not apply to generated concrete types. We may wish to relax this in future. The specific case that triggered it was an inner type a<b>::c, where we were unable to generate C++ to apply <b> to a instead of c because that information was not present in bindgen. * We do not generate methods for things in anonymous namespaces, because we can't refer to them correctly in C++ code. This latter fix is both too aggressive and too weak. It's too weak because it just prevents us making methods on these things; if the types are used as function parameters or return values we will still mis-generate code containing "_bindgen_mod_XYZ" in C++. On the other hand it might be that the better fix is to go ahead and generate C++ code for these things, just stripping out the _bindgen_mod_XYZ bits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087 through multiple different fixes: