Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell bindgen to skip rustfmt #1109

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Conversation

bsilver8192
Copy link
Contributor

The intermediate code is only for code to parse, so formatting is a
waste of time. Also it prints an annoying message when it can't find
rustfmt otherwise.

The intermediate code is only for code to parse, so formatting is a
waste of time. Also it prints an annoying message when it can't find
rustfmt otherwise.
@adetaylor
Copy link
Collaborator

I'm not sure about this one yet. The bindgen output is essential when diagnosing lots of problems and I don't really want to cause extra friction by requiring I copy and paste it into a file to rustfmt it. One partial solution might be to use rustfmt only if RUST_LOG is set. What do you think?

@bsilver8192
Copy link
Contributor Author

I'm not sure about this one yet. The bindgen output is essential when diagnosing lots of problems and I don't really want to cause extra friction by requiring I copy and paste it into a file to rustfmt it. One partial solution might be to use rustfmt only if RUST_LOG is set. What do you think?

Sounds good, done.

@adetaylor adetaylor merged commit b5486fa into google:main Jun 2, 2022
@bsilver8192 bsilver8192 deleted the bindgen-skip-rustfmt branch June 2, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants