Reduce the number of dependencies on std #1224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #1204
I separated the changes to the integration tests into a separate commit in case we don't want to change them.
Some other things I considered doing in this PR, but have other breakages:
std::os::raw::*
tocore::ffi::*
String
toalloc::string::String
when generating the string utilitiesextern crate alloc;
somewhere, and I'm not sure where we want to do that, or if we want to do that unconditionally.std::boxed::Box
toalloc::boxed::Box
I'm not sure what changes I'd make to the readme for this, but I figure that's something to consider once the tests are fixed.
Testing to ensure this change does what I want it to is actually somewhat difficult, as ideally you'd test against a target that is no_std (so that accidental std inclusions get caught), but has a c++ toolchain with lib(std)c++ available (so that cxx compiles, and so that the generated autocxx code compiles). building with zig doesn't help because it doesn't build lib(std)c++ for you. There probably is a target that wouldn't be too difficult to set that up for, but I haven't put much time into looking for one.