Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to autocxx_gen to create cxx.h #1253

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Feb 21, 2023

Fixes #1246

This patch adds an additional command line option to autocxx_gen to create cxx.h.

Currently cxx.h needs to be present and autocxx_gen specifies the location of cxx.h.
This patch allows users to generate cxx.h like autocxx_build.

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@nak3
Copy link
Contributor Author

nak3 commented Feb 21, 2023

I'm adding the option name as generate-cxx-h not gen-cxx-h to distinguish the gen-* family (gen-cpp, gen-rs-include, etc) which is the mandatory options.
Please let me know if gen-cxx-h or other name should be used.

@adetaylor
Copy link
Collaborator

Thanks! That naming decision making sounds good to me.

@adetaylor adetaylor merged commit c3771d0 into google:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Generate cxx.h via autocxx-gen command by an option or by default
2 participants