Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 404 in examples document #1257

Merged
merged 3 commits into from
Mar 6, 2023
Merged

fix 404 in examples document #1257

merged 3 commits into from
Mar 6, 2023

Conversation

htynkn
Copy link
Contributor

@htynkn htynkn commented Mar 6, 2023

Fix link issue in document

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@google-cla
Copy link

google-cla bot commented Mar 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@@ -4,7 +4,7 @@
* [S2 example](https://github.com/google/autocxx/tree/main/examples/s2) - example using S2 geometry library
* [Steam example](https://github.com/google/autocxx/tree/main/examples/steam-mini) - example using (something like) the Steam client library
* [Subclass example](https://github.com/google/autocxx/tree/main/examples/subclass) - example using subclasses
* [Integration tests](https://github.com/google/autocxx/blob/main/integration-tests/src/tests.rs)
* [Integration tests](https://github.com/google/autocxx/blob/main/integration-tests/src/lib.rs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, good spot! However this is the file we now need to link to:
https://github.com/google/autocxx/blob/main/integration-tests/tests/integration_test.rs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, good spot! However this is the file we now need to link to: https://github.com/google/autocxx/blob/main/integration-tests/tests/integration_test.rs

Thank you. Fixed

@adetaylor adetaylor merged commit 9f5c550 into google:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants