Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix for 1289 ("Support for anonymous enums") #1291

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Test and fix for 1289 ("Support for anonymous enums") #1291

merged 2 commits into from
Jun 7, 2023

Conversation

badicsalex
Copy link
Contributor

Test and draft fix for #1289

The actual fix patch is very crude and I doubt this is the best way to do it, but it makes the tests pass at least, and I didn't have that much time to go through the autocxx source.

  • Tests pass
  • Appropriate changes to README are included in PR

@google-cla
Copy link

google-cla bot commented Jun 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adetaylor
Copy link
Collaborator

Thanks a ton for the test case and the attempted fix. Let's see what happens on the existing test suite!

@adetaylor adetaylor merged commit 6cb6d58 into google:main Jun 7, 2023
19 checks passed
@adetaylor
Copy link
Collaborator

Ideally this would generate an error message at a later analysis phase, so that people get rustdoc explaining what went wrong, but this is a good start, thanks!

@badicsalex
Copy link
Contributor Author

Nice. This was super quick, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants