functioninfo.h:163 Check failed: logical_num > 0 (0 vs. 0)

[ChenhaoZhang]

I'm using the gcc version of autofdo tool. And when I tried to convert my perf.data into gcov file, the tool reports an error as below:

F20210608 11:36:58.429226 49029 functioninfo.h:163] Check failed: logical_num > 0 (0 vs. 0)
*** Check failure stack trace: ***
Aborted

The commands that I'm using to collect perf.data and convert it are:
perf record -b "my binary"
./create_gcov --binary=../battle_data/battlesvr --profile=../battle_data/perf.data_battle --gcov=ver1.1_print.gcov -gcov_version=1

In addition, I have tried to build a llvm version of the autofdo tool and it successfully converts the perf.data. Any help would be appreciated!

[wmi0]

Could you give a reproducible, for example attach the binary and the profile?

[ChenhaoZhang]

Could you give a reproducible, for example attach the binary and the profile?
Yes! But could you provide me an email address since the zipped file of the binary and the profile still excesses the maximum size supported.

[wmi0]

You can send it to wmi@google.com. Thanks!

[ChenhaoZhang]

You can send it to wmi@google.com. Thanks!

Sent.

[wmi0]

Got it, thanks Chenhao.

…

On Wed, Jun 9, 2021 at 6:44 PM Chenhao Zhang ***@***.***> wrote: You can send it to ***@***.*** Thanks! Sent. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJCYKFKYWS7PRMCCZPMNLLLTSAKIJANCNFSM46JJRZXQ> .

[rekyyang]

I met the same problem, has it been solved?

[rekyyang]

I solved it by sampling perf.data using perf record -b -e br_inst_retired.near_taken:pp -p 1 -- sleep 120
and complie with -g option in the first compilation, and remove the -g option in the second compilation

https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html ， and search key word autofdo

[grajer]

I also meet this problem, when convert redis profiling data to .gcov. Is there any solution?

[wmi0]

I am still working on the issue. The old dwarf reader had some bug and looks like a newer version could possibly fix the issue (The whole dwarf reader has been deprecated internally since google switched to use llvm-symbolizer. I was trying to find a relatively new version before the deprecation but there was still some issue to be solved).

…

On Fri, Jun 25, 2021 at 7:43 PM grajer ***@***.***> wrote: I also meet this problem, when convert redis profiling data to .gcov. Is there any solution? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJCYKFJAKT4WYTI5XFQWNXTTUU5FRANCNFSM46JJRZXQ> .

[softrobotYCLi]

Hi all, I also meet this problem and solved it by compare with old create_gcov.
little example can recurrence this problem:

#include <iostream>
#include <stdlib.h>
inline int foobar(int a, int b)
{
  if (a < b)
    return a;
  a = rand();
  b = rand();
  return a-b;
}

int bar(int a) {
  a+=rand();
  return a;
}

int foo(int a, int b)
{
  return bar(foobar(a,b));
}

int main()
{
  int a = 1;
  int j = 10000000;
  while (j--)
    a+= foo(rand(),rand());
  std::cout << a << endl;
  return 0;
}

The solution is:

--- a/legacy_addr2line.cc
+++ b/legacy_addr2line.cc
@@ -184,6 +184,9 @@ void Google3Addr2line::GetInlineStack(uint64_t address,
   if (iter == line_map_->begin())
     return;
   --iter;
+  if (iter->second == 0) {
+    return;
+  }
   const LineIdentifier &LI = line_map_->GetLogical(iter->second);
   if (LI.line == 0)
     return;

hope it`s useful ^_^

[wmi0]

Thanks for pointing that out! I somehow dropped that line when I was doing the merge. The suggested fix solves the problem. Will merge it.

[wmi0]

Fix committed: 8d5bf56