Ignore implicit ctors in anonymous structs. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For anonymous structs Clang generates no name for its implicit ctor. This was confusing the profile reader in LLVM. Since we can't really map an empty name to a callgraph node, this patch simply ignores anonymous structs. This should not be an issue. If an anonymous struct has a substantial amount of cycles in its ctor, so will its parent. Additonally, this patch makes the profile converter ignore functions for which we have no locations with non-zero samples. They are not worth writing out.
danielcdh
added a commit
that referenced
this pull request
May 30, 2014
Ignore implicit ctors in anonymous structs.
This was referenced May 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For anonymous structs Clang generates no name for its implicit ctor. This
was confusing the profile reader in LLVM. Since we can't really map
an empty name to a callgraph node, this patch simply ignores anonymous
structs.
This should not be an issue. If an anonymous struct has a substantial
amount of cycles in its ctor, so will its parent.
Additonally, this patch makes the profile converter ignore functions
for which we have no locations with non-zero samples. They are not
worth writing out.