-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for comparison between ID/TYPE bindings and text literals inside HAVING clauses #117
Conversation
3f21963
to
50209b2
Compare
ecebbbf
to
f67dec4
Compare
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
224846e
to
7efe586
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
ead17f6
to
69ca15d
Compare
db137f3
to
42c8d0d
Compare
8726d36
to
8c55ab9
Compare
…g bindings (eg: ID) and text literals
…th incoherent literals
…ORE clauses, inside "planner_test.go"
… compare a ^^type:int64 to a ^^type:float64)
e8349fb
to
a317b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Roger! I hope this helps :)
Previously, comparisons between ID bindings and text literals inside HAVING clauses (such as below) were not effective:
Now, they are fully supported (
<
,>
and=
), proceeding as a lexicographical comparison between the ID binding and the text literal that follows.The same is now supported for bindings created using the TYPE keyword too.
Error handling for comparison expressions were also improved.