-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support predicate binding equalities inside HAVING clauses #137
Merged
thiagovas
merged 10 commits into
google:master
from
rogerlucena:predicate-equality-having
Aug 25, 2020
Merged
Support predicate binding equalities inside HAVING clauses #137
thiagovas
merged 10 commits into
google:master
from
rogerlucena:predicate-equality-having
Aug 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbkloss
approved these changes
Aug 19, 2020
thiagovas
requested changes
Aug 20, 2020
rogerlucena
force-pushed
the
predicate-equality-having
branch
from
August 21, 2020 19:41
bd3e870
to
b7cd0f3
Compare
thiagovas
approved these changes
Aug 22, 2020
Tati1701
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style comments, otherwise good to go :)
Please resolve them before submitting. Feel free to reach out if you have any questions.
…ression_test.go")
rogerlucena
force-pushed
the
predicate-equality-having
branch
from
August 25, 2020 16:09
3ed4115
to
2e4c76b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now compare a predicate binding to a predicate literal inside the
HAVING
clause (only equalities allowed) to filter the results of our query.To illustrate, the following query is now possible:
Note that predicate inequalities are not allowed because their behavior may become confusing for the user (especially when time anchors come on stage). In this case an error is prompted orienting to extract bindings with the
ID
/AT
keywords and to use these bindings to proceed with the comparisons in a clearer way.