New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark redefines CHECK() in glog #62

Closed

eddyxu opened this issue Oct 26, 2014 · 3 comments · Fixed by #63

Assignees

Labels

bug

Contributor

eddyxu commented Oct 26, 2014

Since benchmark/macros.h defines CHECK_XXX, it prevents to use both glog/logging.h and benchmark/benchmark.h in the same file.

The text was updated successfully, but these errors were encountered:

Member

dmah42 commented Oct 29, 2014

I'm trying to think what the right solution is here.

Maybe benchmark should explicitly depend on glog and use the macros from there directly.

Another option is to check if they're defined before defining them.

I think I prefer the first, but I'm open to other thoughts!

dmah42 self-assigned this

dmah42 added the bug label

Contributor

ckennelly commented Oct 29, 2014

Is it even necessary to export the CHECK_XXX macros at all in the header file? These are being used internally rather than in benchmark.h.

Member

dmah42 commented Nov 1, 2014

They are used in benchmark_test.cc which doesn't (yet!) depend on googletest. Maybe it should ;)

dmah42 added a commit that referenced this issue


          Remove CHECK_* from public API.

a3b5e44

CHECK_* are now private and used internally in the library. The test
uses have been replaced with asserts.

Fixes #62.

dmah42 mentioned this issue

Remove CHECK_* from public API. #63

Merged

dmah42 closed this as completed in #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment