Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Appveyor builds are failing, but are showing green #689

Closed
staffantj opened this issue Sep 21, 2018 · 2 comments
Closed

Windows Appveyor builds are failing, but are showing green #689

staffantj opened this issue Sep 21, 2018 · 2 comments

Comments

@staffantj
Copy link
Contributor

Since 1b44120 the Windows Appveyor builds have been reporting warnings, but they are showing green since warnings aren't set to convert to errors, basically making the integration builds worthless.

@LebedevRI
Copy link
Collaborator

The Appveyor build is red since https://ci.appveyor.com/project/google/benchmark/build/1401/job/2u8kwhb363sxvg7j anyway.
That failure looked rather cryptic to me, so i did nothing.
I suspect that is why those msvc builds are not warning-as-error in the first place.

@staffantj
Copy link
Contributor Author

It looks as if the build break (as opposed to the warnings) comes out of gmock, with an "no idea what warning 5046 is" error message.

It doesn't really make sense that it suddenly appears at the point in the build history where it does, unless there's something about the build environment changing that Appveyor isn't showing me.

Certainly it looks as if there has pretty much always been warnings in the Windows build (at least going back some time).

I might try attacking some of those once/if I get the attribution paperwork in order.

I've traced the C4512 warnings down to the State* const parent_ member on the StateIterator. Should that by any chance be a State const* ?

LebedevRI added a commit to LebedevRI/benchmark that referenced this issue Sep 25, 2018
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this issue Dec 6, 2018
LebedevRI added a commit that referenced this issue Aug 21, 2019
VS2013 is unsupported since #691 / eb8cbec
but i forgot to update docs.
References:
* #689
* #691
* google/googletest#1815
* #853
* #854
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this issue Sep 11, 2020
VS2013 is unsupported since google#691 / google@eb8cbec
but i forgot to update docs.
References:
* google#689
* google#691
* google/googletest#1815
* google#853
* google#854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants