Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-tests fail to build due to signed/unsigned integer comparisons #741

Closed
Sigill opened this issue Dec 8, 2018 · 0 comments
Closed

Unit-tests fail to build due to signed/unsigned integer comparisons #741

Sigill opened this issue Dec 8, 2018 · 0 comments

Comments

@Sigill
Copy link
Contributor

Sigill commented Dec 8, 2018

Debian 9.5 Stretch / GCC 6.3.0 / Googletest 1.8.1

The string_utils unit-tests fail to build with the following error:

/home/cfx/Dev/google-benchmark/benchmark.git/test/string_util_gtest.cc:12:5:   required from here
/home/cfx/Applications/googletest-1.8.1/include/gtest/gtest.h:1444:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   if (lhs == rhs) {
       ~~~~^~~~~~
Sigill added a commit to Sigill/benchmark that referenced this issue Dec 8, 2018
Unit-tests fail to build due to the following errors:

/home/cfx/Dev/google-benchmark/benchmark.git/test/string_util_gtest.cc:12:5: required from here
/home/cfx/Applications/googletest-1.8.1/include/gtest/gtest.h:1444:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   if (lhs == rhs) {
       ~~~~^~~~~~

Fixes google#741
@Sigill Sigill changed the title Unit-tests fail to build doe to signed/unsigned integer comparisons Unit-tests fail to build due to signed/unsigned integer comparisons Dec 8, 2018
dmah42 pushed a commit that referenced this issue Dec 10, 2018
Unit-tests fail to build due to the following errors:

/home/cfx/Dev/google-benchmark/benchmark.git/test/string_util_gtest.cc:12:5: required from here
/home/cfx/Applications/googletest-1.8.1/include/gtest/gtest.h:1444:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   if (lhs == rhs) {
       ~~~~^~~~~~

Fixes #741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant