Revert previous linker additions for FreeBSD as the problem is Bazel … #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using /usr/bin/clang instead of /usr/bin/clang++ to link C++ code.
|
Thanks for following up and cleaning up :) |
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Sep 11, 2020
…using /usr/bin/clang instead of /usr/bin/clang++ to link C++ code. (google#1035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…using
/usr/bin/clanginstead of/usr/bin/clang++to link C++ code.The correct fix for this and several other libraries would be getting Bazel to use
/usr/bin/clang++to link C++ code firstand then fix any remaining linker errors.
See: bazelbuild/bazel#12023