Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perf counter argument parsing #1160

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

0xfeedface
Copy link
Contributor

@0xfeedface 0xfeedface commented May 31, 2021

This fixes a bug where providing multiple perf counters via --benchmark_perf_counters does not parse correctly:

% ./benchmark_bin --benchmark_perf_counters=instructions,cache-misses,branch-misses
...
Unknown counter name: cache-misses,branch-misses

@google-cla
Copy link

google-cla bot commented May 31, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 31, 2021
@0xfeedface 0xfeedface force-pushed the fix-perf-counter-argument-parsing branch from 0845ef8 to d80e64f Compare May 31, 2021 14:20
@google-cla
Copy link

google-cla bot commented May 31, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@0xfeedface 0xfeedface force-pushed the fix-perf-counter-argument-parsing branch from d80e64f to 3463468 Compare May 31, 2021 14:22
@google-cla google-cla bot added cla: yes and removed cla: no labels May 31, 2021
@dmah42
Copy link
Member

dmah42 commented Jun 1, 2021

Well spotted, and thank you for also updating the tests.

@dmah42 dmah42 merged commit 6f094ba into google:main Jun 1, 2021
vincenzopalazzo pushed a commit to vincenzopalazzo/benchmark that referenced this pull request Feb 8, 2022
* Fix argument order in StrSplit

* Update AUTHORS, CONTRIBUTORS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants