Add setuptools_scm for dynamic zero-config Python versioning
#1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for manually bumping versions in the Python bindings. For the wheel uploads, the correct semver version is inferred in the case of tagged commits, which is exactly the case in GitHub CI. The docs were updated to reflect the changes in the release workflow.
This is the best practice mentioned in the `setuptools_scm` docs, see https://setuptools-scm.readthedocs.io/en/latest/usage/#version-at-runtime.
nicholasjng
force-pushed
the
add-setuptools-scm
branch
from
ab7ecc0
to
e1b69d5
Compare
dmah42
approved these changes
Nov 1, 2023
|
much better. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for manually bumping versions in the Python bindings.
For the wheel uploads, the correct semver version is inferred in the case of tagged commits, which is exactly the case in GitHub CI.
The docs were updated to reflect the changes in the release workflow.
We also add a runtime-useable version, which is the best practice mentioned in the
setuptools_scmdocs, see https://setuptools-scm.readthedocs.io/en/latest/usage/#version-at-runtime.