Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C-style typecasting in QNX-specific code #1739

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix C-style typecasting in QNX-specific code #1739

merged 1 commit into from
Jan 16, 2024

Conversation

Arech
Copy link
Contributor

@Arech Arech commented Jan 16, 2024

C-style typecasting breaks the build due to -Werror=old-style-cast which should remain in place.

Resolves #1707

C-style typecasting breaks the build due to `-Werror=old-style-cast` which should remain in place.
Copy link

google-cla bot commented Jan 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Arech
Copy link
Contributor Author

Arech commented Jan 16, 2024

complexity_benchmark is failing with a pretty cryptic error to me.

66: BM_Complexity_O_N/2048         D:/a/benchmark/benchmark/test/output_test_helper.cc:116: CheckCase: Check `TC.match_rule != MR_Next' failed. Expected line "BM_Complexity_O_N_RMS                              7 %            25 %    " to match regex "^%rms_name %rms %rms[ ]*$"
66:     actual regex string "^BM_Complexity_O1_RMS [ ]*[0-9]+ % [ ]*[0-9]+ %[ ]*$"
66:     started matching near: BM_Complexity_O_N_RMS                              7 %            25 %    
66:                 11826 ns        15625 ns         1000

https://github.com/google/benchmark/actions/runs/7540451018/job/20525988749?pr=1739#step:6:5222

I don't think it might ever be affected by the PR. Can anyone please suggest what to do?

@dmah42
Copy link
Member

dmah42 commented Jan 16, 2024

complexity_benchmark is failing with a pretty cryptic error to me.

66: BM_Complexity_O_N/2048         D:/a/benchmark/benchmark/test/output_test_helper.cc:116: CheckCase: Check `TC.match_rule != MR_Next' failed. Expected line "BM_Complexity_O_N_RMS                              7 %            25 %    " to match regex "^%rms_name %rms %rms[ ]*$"
66:     actual regex string "^BM_Complexity_O1_RMS [ ]*[0-9]+ % [ ]*[0-9]+ %[ ]*$"
66:     started matching near: BM_Complexity_O_N_RMS                              7 %            25 %    
66:                 11826 ns        15625 ns         1000

https://github.com/google/benchmark/actions/runs/7540451018/job/20525988749?pr=1739#step:6:5222

I don't think it might ever be affected by the PR. Can anyone please suggest what to do?

this is generally flaky, unfortunately. don't worry about it.

@Arech
Copy link
Contributor Author

Arech commented Jan 16, 2024

@dmah42 ah, so it won't break the merge process then? Ok, then it looks like my role is over here and I presume it should merge automatically. Thanks for a quick review!

@dmah42 dmah42 merged commit 3d293cd into google:main Jan 16, 2024
80 checks passed
@dmah42
Copy link
Member

dmah42 commented Jan 16, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] QNX compilation failure on v1.8.3. Patch suggestion.
2 participants