Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove COMPILER_IBMXL macro for z/OS #1777

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

fanbo-meng
Copy link
Contributor

This patch removes definition and usage of COMPILER_IBMXL macro, resolves issue #1776

COMPILER_IBMXL identifies the Clang based IBM XL compiler (xlclang) on z/OS. This compiler is obsolete and replaced by the Open XL compiler, so the macro is no longer needed and the existing code would lead to incorrect asm syntax for Open XL.
@LebedevRI
Copy link
Collaborator

I'm guessing that ecosystem/hardware is so special we (well, you) get to dictate that said obsolete compiler is simply completely unsupported going forward, and thus such change is fine?

@dmah42 dmah42 merged commit 70916cb into google:main Apr 3, 2024
80 checks passed
@dmah42
Copy link
Member

dmah42 commented Apr 3, 2024

thanks. and thanks for the commit description :)

@fanbo-meng fanbo-meng deleted the zos-asm-syntax branch April 3, 2024 12:18
@fanbo-meng
Copy link
Contributor Author

fanbo-meng commented Apr 3, 2024

I'm guessing that ecosystem/hardware is so special we (well, you) get to dictate that said obsolete compiler is simply completely unsupported going forward, and thus such change is fine?

Yes I'm from the dev team of z/OS C/C++ compiler. That macro isn't used anywhere else other than the one instance in cycleclock.h, and after this change the code would still compile the same way (for that compiler). Thus IMHO we aren't exactly removing support and this change is fine.

@LebedevRI
Copy link
Collaborator

Yup, thank you, i just wanted that to be explicitly stated.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants