Remove COMPILER_IBMXL macro for z/OS #1777
Conversation
fanbo-meng
force-pushed
the
zos-asm-syntax
branch
from
80408d6
to
841ff36
Compare
COMPILER_IBMXL identifies the Clang based IBM XL compiler (xlclang) on z/OS. This compiler is obsolete and replaced by the Open XL compiler, so the macro is no longer needed and the existing code would lead to incorrect asm syntax for Open XL.
fanbo-meng
force-pushed
the
zos-asm-syntax
branch
from
841ff36
to
2ebb007
Compare
|
I'm guessing that ecosystem/hardware is so special we (well, you) get to dictate that said obsolete compiler is simply completely unsupported going forward, and thus such change is fine? |
|
thanks. and thanks for the commit description :) |
Yes I'm from the dev team of z/OS C/C++ compiler. That macro isn't used anywhere else other than the one instance in cycleclock.h, and after this change the code would still compile the same way (for that compiler). Thus IMHO we aren't exactly removing support and this change is fine. |
|
Yup, thank you, i just wanted that to be explicitly stated. |
This patch removes definition and usage of COMPILER_IBMXL macro, resolves issue #1776