[NFC] RunBenchmarks(): s/has_repetitions/might_have_aggregates/ #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is the real purpose of that bool. A follow-up change will make it consider something else other than repetitions.
LebedevRI
requested review from
dmah42 and
EricWF
and removed request for
dmah42
|
✅ Build benchmark 1531 completed (commit dcb7aea9f9 by @LebedevRI) |
dmah42
approved these changes
Oct 18, 2018
|
Thank you for the review! |
EricWF
pushed a commit
to efcs/benchmark
that referenced
this pull request
Nov 29, 2018
…le#707) That is the real purpose of that bool. A follow-up change will make it consider something else other than repetitions.
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Dec 6, 2018
…le#707) That is the real purpose of that bool. A follow-up change will make it consider something else other than repetitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is the real purpose of that bool. A follow-up change will
make it consider something else other than repetitions.