StrFormat() is a printf-like function, mark it as such, fix fallout. #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build benchmark 1573 failed (commit d342a80563 by @LebedevRI) |
|
❌ Build benchmark 1574 failed (commit c9cd2e6927 by @LebedevRI) |
LebedevRI
force-pushed
the
print-range
branch
2 times, most recently
from
f431fcd
to
b7387f0
Compare
|
❌ Build benchmark 1576 failed (commit ed94bded4a by @LebedevRI) |
LebedevRI
force-pushed
the
print-range
branch
from
b7387f0
to
d3d93df
Compare
|
❌ Build benchmark 1578 failed (commit b12d0c87e3 by @LebedevRI) |
LebedevRI
force-pushed
the
print-range
branch
from
d3d93df
to
1ad81ce
Compare
|
✅ Build benchmark 1579 completed (commit 67c53f8cf4 by @LebedevRI) |
|
✅ Build benchmark 1580 completed (commit 376b12b007 by @LebedevRI) |
|
LGTM. Thanks. |
|
Thank you for the review! |
EricWF
pushed a commit
to efcs/benchmark
that referenced
this pull request
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #714.