Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Add sample openroad configuration to build fp_multiplier #17

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Add sample openroad configuration to build fp_multiplier #17

merged 1 commit into from
Aug 5, 2022

Conversation

growly
Copy link
Contributor

@growly growly commented Aug 5, 2022

No description provided.

@growly growly requested a review from mithro August 5, 2022 01:41
mithro
mithro approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

LGTM otherwise.

example_inputs/fp_multiplier/openroad_config/README Outdated
@@ -0,0 +1,97 @@
To get OpenROAD to work on this design I had to disable CTS and assign pins the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you rename this to README.md so the file renders in GitHub interface.

example_inputs/fp_multiplier/openroad_config/README Outdated
hard way. Here is a diff of the changes, since I don't expect the code will be
stable enough to warrant a patch file:

````
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use the following you should get syntax highlighting;


  ```diff

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks

example_inputs/fp_multiplier/openroad_config/fp_multiplier/config.mk
@@ -0,0 +1,52 @@
DESIGN_DIR := $(realpath $(shell dirname $(realpath $(lastword $(MAKEFILE_LIST)))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need license header.

@growly growly requested a review from mithro August 5, 2022 18:02
@growly
Copy link
Contributor Author

growly commented Aug 5, 2022

tyvm

@mithro mithro merged commit 2f4e28a into main Aug 5, 2022
@mithro mithro deleted the add-fp-multiplier-or branch August 5, 2022 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@growly @mithro