Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClearRenderTarget/ClearDepthStencil don't work with dynamic render passes #408

Open
apazylbe opened this issue Jan 16, 2024 · 1 comment
Assignees

Comments

@apazylbe
Copy link
Collaborator

This is a follow up from #356

ClearRenderTarget/ClearDepthStencil (

void CommandBuffer::ClearRenderTarget(
) accept an image and clear an image while inside a render pass. The functions use current render pass variable to figure out the attachment index and and render area. When we have a dynamic render pass we can look up the attachment index by the image instead of the image view and save the render area on BeginRendering and BeginRenderpass. We would also have to check that there is an active render pass here
if (IsNull(pCurrentRenderPass)) {
with HasActiveRenderPass

Keenuts pushed a commit that referenced this issue Feb 2, 2024
…ing (#414)

For issue #408  

ClearRenderTarget and ClearDepthStencil now work within a dynamic render
pass. RenderArea is now saved directly in BeginRendering.

DynamicRendering sample is updated to call both these functions. These
functions still work in the Cube sample as well (for a non dynamic
rendering example).
@alizahlalani
Copy link
Collaborator

pull #414 does not address DX12

As a follow up - before this issue can be closed, changes also need to be made for DX12 - https://github.com/google/bigwheels/blob/main/src/ppx/grfx/dx12/dx12_command.cpp#L416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants