Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win Build] fatal error C1083: Cannot open include file: 'third_party/zynamics/binexport/version.h': No such file or directory #1

Closed
schomatis opened this issue Mar 11, 2016 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@schomatis
Copy link

Hi, I'm trying to build the plugin in Windows with the above error. This file that's missing is included in main_plugin.cc and is expected to be in third_party\zynamics\binexport, which is actually a link to the root dir, where the version.h.in file is located. The file is created in the CmakeLists.txt:

configure_file(version.h.in version.h ESCAPE_QUOTES @ONLY)

When using configure_file with relative paths, the input is relative to CMAKE_CURRENT_SOURCE_DIR and the output to CMAKE_CURRENT_BINARY_DIR .

In the Windows build, which is out-of-source, these dirs are not the same, the source dir is the root dir but the binary dir is build_msvc, so version.h ends up there, and not in the root (build_msvc parent's) dir. As a quick (and dirty) fix I've changed the output file path to:

configure_file(version.h.in ../version.h ESCAPE_QUOTES @ONLY)

But looking at the configure file used in the Linux and OS X builds, these seem to be in-source, so the previous change will likely break them, needing a cleaner fix than mine.

Lucas

@cblichmann cblichmann added the bug Something isn't working label Mar 11, 2016
@cblichmann cblichmann self-assigned this Mar 11, 2016
@cblichmann
Copy link
Member

Thanks for the bug report.
You could also just do an in-source build -- messy, but it should work. The error was likely left in there because I copied the complete source over to my Windows machine; I must've copied the generated version.h file but did not check it in.

@cblichmann
Copy link
Member

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants