Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to have multiple hexagon binaries in same binaryninja instance #2

Open
bambu opened this issue Mar 20, 2021 · 3 comments
Open

Comments

@bambu
Copy link

bambu commented Mar 20, 2021

Didn't see this caveat in the docs, when there are multiple hexagon binaries open in the same binary ninja process, the disassembly for both of them at a specific address is the same despite them having different instructions.

Looks like packets are being cached by address and the plugin does not take into account the current BinaryView for that address. When a user opens a different hexagon binary and goes to the same address that was previously cached, instead of attempting to disassemble the current bytes, it disassembles the already cached bytes from the other tab.

Since it is cached at the plugin level and not the view, closing all hexagon tabs and opening up a new file (that isn't the original file cached) will still show the cached data from the initial file.

@cfircohen
Copy link
Contributor

Thanks for submitting this!

Presently, GetInstructionInfo and GetInstructionText architecture callbacks don't pass the current BinaryView object, and I couldn't find a direct way to get it.

I'll have to ask the Binary ninja forks how to address this, since I think this is currently a limitation in the API.

@cfircohen
Copy link
Contributor

Started Vector35/binaryninja-api#2328

@cfircohen
Copy link
Contributor

Peter LaFosse: "#551 This is unfortunately a know limitation that we are working to remedy."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants