Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Removing BlockWorkspaceParams and FieldWorkspaceParams #123

Merged
merged 1 commit into from Mar 16, 2016

Conversation

AnmAtAnm
Copy link
Contributor

This change is Reviewable

@AnmAtAnm AnmAtAnm changed the title Removing BlockWorkspaceParams and FieldWorkspaceParams. Removing BlockWorkspaceParams and FieldWorkspaceParams Mar 16, 2016
@AnmAtAnm
Copy link
Contributor Author

PTAL @RoboErikG


Review status: 0 of 15 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@rachel-fenichel
Copy link
Contributor

One comment and lgtm


Review status: 0 of 15 files reviewed at latest revision, 1 unresolved discussion.


blocklylib/src/main/java/com/google/blockly/ui/fieldview/FieldLabelView.java, line 54 [r1] (raw file):
Also remove mWorkspaceHelper?


Comments from the review on Reviewable.io

@AnmAtAnm
Copy link
Contributor Author

Review status: 0 of 15 files reviewed at latest revision, 1 unresolved discussion.


blocklylib/src/main/java/com/google/blockly/ui/fieldview/FieldLabelView.java, line 54 [r1] (raw file):
Used in configureStyle(..) to get field style.


Comments from the review on Reviewable.io

@AnmAtAnm AnmAtAnm force-pushed the AnmAtAnm-rm-workspaceparams branch from 05d43e7 to d5792f8 Compare March 16, 2016 16:44
AnmAtAnm added a commit that referenced this pull request Mar 16, 2016
Removing BlockWorkspaceParams and FieldWorkspaceParams
@AnmAtAnm AnmAtAnm merged commit 644e858 into master Mar 16, 2016
@AnmAtAnm AnmAtAnm deleted the AnmAtAnm-rm-workspaceparams branch March 16, 2016 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants