Filter dummy ducks while getting opponents #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moniika
reviewed
Feb 3, 2020
appengine/pond_storage/opponents.py
Outdated
Comment on lines
168
to
169
| logging.info("entries_to_duck_info : Dummy ducks should be filtered earlier" + | ||
| "on"); |
There was a problem hiding this comment.
This seems like debugging info, should be removed
appengine/pond_storage/opponents.py
Outdated
Comment on lines
63
to
64
| if e not in opponent_entries and e.key != user_entry.key and | ||
| e.has_duck == True] |
There was a problem hiding this comment.
Instead of filtering afterward, you can add to query. rank.py L123 has example. It can be added because its an equality check.
moniika
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter dummy ducks before returning from opponents.