fix: Fix incorrect Blockly imports (#2339)

We have for some time promulgated

   import * as Blockly from 'blockly/core';

as the correct way to import Blockly in our documentation.
Update our own plugins and templates to match.

Because we have been packaging Blockly until now only as CJS
modules, and CJS modules always provide an (unnamed) default
export consisting of the module.exports object, importing
Blockly with

    import Blockly from 'blockly/core';

(note no "*") has worked fine (and similarly for all the
other entrypoints).

As the sources for the entrypoints (core/blockly.ts,
blocks/blocks.ts, etc.) do not explicitly declare a default
export, however, this should not be relied upon: when we start
shipping Blockly as pure-ESM there will be no default export
and so "import Blockly from …" will stop working.

plugins/block-plus-minus/src/if.js

@@ -8,7 +8,7 @@
  * @fileoverview Changes the if block to use a +/- mutator UI.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 import {createMinusField} from './field_minus';
 import {createPlusField} from './field_plus';
 

plugins/block-plus-minus/src/list_create.js

@@ -8,7 +8,7 @@
  * @fileoverview Changes the list_create block to use a +/- mutator UI.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 import {createPlusField} from './field_plus';
 import {createMinusField} from './field_minus';
 

plugins/block-plus-minus/src/procedures.js

@@ -8,7 +8,7 @@
  * @fileoverview Changes the procedure blocks to use a +/- mutator UI.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 import {createMinusField} from './field_minus';
 import {createPlusField} from './field_plus';
 

plugins/block-plus-minus/src/text_join.js

@@ -8,7 +8,7 @@
  * @fileoverview Changes the text_join block to use a +/- mutator UI.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 import {createPlusField} from './field_plus';
 import {createMinusField} from './field_minus';
 

plugins/block-test/src/serialization/blocks.js

@@ -7,7 +7,7 @@
 
 'use strict';
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 import './fields';
 
 Blockly.defineBlocksWithJsonArray([

plugins/block-test/src/serialization/category.js

@@ -6,7 +6,7 @@
 
 'use strict';
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 import './blocks';
 
 /**

plugins/block-test/src/serialization/fields.js

@@ -6,7 +6,7 @@
 
 'use strict';
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 /**
  * Field that does not override any serialization hooks.

plugins/dev-create/templates/block/template/src/index.js

@@ -9,7 +9,7 @@
  * @fileoverview Block overview.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 // TODO: Update block definition.
 Blockly.defineBlocksWithJsonArray([

plugins/dev-create/templates/field/template/src/index.js

@@ -9,7 +9,7 @@
  * @fileoverview Field overview.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 // TODO: Rename field and update description.
 /**

plugins/dev-create/templates/theme/template/src/index.js

@@ -9,7 +9,7 @@
  * @fileoverview Theme overview.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 // TODO: Edit theme name.
 export default Blockly.Theme.defineTheme('THEME_NAME', {

plugins/dev-create/templates/typescript-block/template/src/index.ts

@@ -9,7 +9,7 @@
  * @fileoverview Block overview.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 // TODO: Update block definition.
 Blockly.defineBlocksWithJsonArray([

plugins/dev-tools/src/debugDrawer.js

@@ -8,7 +8,7 @@
  * @fileoverview Visualizer for debugging custom renderers in Blockly.
  * @author fenichel@google.com (Rachel Fenichel)
  */
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 /**
  * A basic visualizer for debugging custom renderers.

plugins/dev-tools/src/populateRandom.js

@@ -8,7 +8,7 @@
  * @fileoverview Helper for randomly populating a workspace.
  * @author fenichel@google.com (Rachel Fenichel)
  */
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 /**
  * Populate the workspace with a random set of blocks, for testing.

plugins/dev-tools/src/screenshot.js

@@ -8,7 +8,7 @@
  * @fileoverview Download screenshot.
  * @author samelh@google.com (Sam El-Husseini)
  */
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 /**
  * Convert an SVG datauri into a PNG datauri.

plugins/dev-tools/src/spaghetti.js

@@ -9,7 +9,7 @@
  * blocks, for testing.
  * @author samelh@google.com (Sam El-Husseini)
  */
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 const spaghettiXml = [
   '  <block type="controls_if">',

plugins/field-bitmap/src/field-bitmap.ts

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 export const DEFAULT_HEIGHT = 5;
 export const DEFAULT_WIDTH = 5;

plugins/fixed-edges/src/index.js

@@ -9,7 +9,7 @@
  * configurable.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 /**
  * @typedef {{

plugins/migration/test/rename.mocha.js

@@ -53,7 +53,7 @@ suite('Rename', function () {
       ],
     };
     const oldString = `
-import Blockly from 'blockly';
+import * as Blockly from 'blockly';
 
 class SubClass extends Blockly.moduleC {
   constructor() {
@@ -81,7 +81,7 @@ class SubClass extends Blockly.moduleC {
     const newString = new Renamer(database, '0.0.0', '1.0.0').rename(oldString);
 
     const expectedString = `
-import Blockly from 'blockly';
+import * as Blockly from 'blockly';
 
 class SubClass extends Blockly.moduleC.ClassC {
   constructor() {

plugins/scroll-options/src/index.js

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 import {EdgeScrollOptions, ScrollBlockDragger} from './ScrollBlockDragger';
 import {getTranslation} from './utils';
 

plugins/theme-dark/src/index.js

@@ -8,7 +8,7 @@
  * @fileoverview Dark theme.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 /**
  * Dark theme.

plugins/theme-deuteranopia/src/index.js

@@ -8,7 +8,7 @@
  * @fileoverview Deuteranopia theme.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 const defaultBlockStyles = {
   colour_blocks: {

plugins/theme-highcontrast/src/index.js

@@ -10,7 +10,7 @@
  * Darker colours to contrast the white font.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 const defaultBlockStyles = {
   colour_blocks: {

plugins/theme-modern/src/index.js

@@ -8,7 +8,7 @@
  * @fileoverview Modern theme.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 export default Blockly.Theme.defineTheme('modern', {
   base: Blockly.Themes.Classic,

plugins/theme-tritanopia/src/index.js

@@ -8,7 +8,7 @@
  * @fileoverview Tritanopia theme.
  */
 
-import Blockly from 'blockly/core';
+import * as Blockly from 'blockly/core';
 
 const defaultBlockStyles = {
   colour_blocks: {