Batch events for writing to the database. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, each event is written to the database as an individual entry. With this change, the client batches any available events and writes them to the database as a single entry. By writing all events to the database in a single entry this removes the need to use a transaction. Other: WorkspaceClient.js: this.inProgress was an array of events, now this.inProgress is an array of LocalEntry objects. Tracking a LocalEntry object facilitates merging client and server events. Currently, only one LocalEntry event will exist at a time, however, once websockets are implemented, inProgress will hold multiple LocalEntry objects.
RoboErikG
reviewed
Nov 20, 2019
blockly-rtc/src/WorkspaceClient.js
Outdated
| this.endWrite_(false); | ||
| throw Error('Failed to write to database.'); | ||
| }; | ||
| this.beginWrite_(); |
There was a problem hiding this comment.
Nit: get rid of the extra indentation here.
rachel-fenichel
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each event is written to the database as an individual entry.
With this change, the client batches any available events and writes
them to the database as a single entry. By writing all events to the
database in a single entry this removes the need to use a transaction.
Other:
WorkspaceClient.js: this.inProgress was an array of events, now
this.inProgress is an array of LocalEntry objects. Tracking a LocalEntry
object facilitates merging client and server events. Currently, only one
LocalEntry event will exist at a time, however, once websockets are
implemented, inProgress will hold multiple LocalEntry objects.