Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update version of webpack-cli to be compatible #976

Merged
merged 1 commit into from Jan 21, 2022

Conversation

maribethb
Copy link
Contributor

We updated to webpack v5 in #879 but webpack-cli v3 isn't compatible with webpack v5. This becomes a problem if you ever install from a clean state: you will get peer dependency errors.

To fix this, I just updated to the latest version of webpack-cli. I didn't extensively check the release notes to see what all changed, but I did run npm run start and npm run build on a plugin to make sure that our webpack processes still work and it seems fine.

@maribethb maribethb merged commit 3bf916b into google:master Jan 21, 2022
@maribethb maribethb deleted the fix-webpack branch April 1, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants