Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldDropdown.validateOptions_ bug #2090

Closed
duzc2 opened this issue Oct 26, 2018 · 2 comments · Fixed by #2174
Closed

FieldDropdown.validateOptions_ bug #2090

duzc2 opened this issue Oct 26, 2018 · 2 comments · Fixed by #2174
Labels
component: tests help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong

Comments

@duzc2
Copy link
Contributor

duzc2 commented Oct 26, 2018

Problem statement

a
@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited labels Nov 5, 2018
@rachel-fenichel
Copy link
Collaborator

Next steps:

  • use tuple instead of options, to validate the correct object
  • add a passing test for the case where tuple is an array and a failing test for the case when tuple is anything else

The current code is too permissive, which probably leads to later bugs.

@duzc2 feel free to make a pull request for this one.

duzc2 added a commit to duzc2/blockly that referenced this issue Nov 7, 2018
@duzc2
fix google#2090
dad8c8e
@duzc2 duzc2 mentioned this issue Nov 7, 2018
Merged
RoboErikG pushed a commit that referenced this issue Nov 7, 2018
@duzc2 @RoboErikG
fix #2090 (#2109)
f3bb0d8
@RoboErikG RoboErikG added component: tests issue: bug Describes why the code or behaviour is wrong and removed issue: bug Describes why the code or behaviour is wrong labels Nov 7, 2018
@RoboErikG
Copy link
Contributor

Underlying bug has been fixed but this could still use a field_dropdown_test.js file in the jsunit folder before we close out the bug.

@rachel-fenichel rachel-fenichel mentioned this issue Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tests help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

December 2018 release google/blockly
3 participants
@duzc2 @RoboErikG @rachel-fenichel