Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAllBlockStyles Annotation Error? #2414

Closed
BeksOmega opened this issue Apr 26, 2019 · 5 comments
Closed

getAllBlockStyles Annotation Error? #2414

BeksOmega opened this issue Apr 26, 2019 · 5 comments
Labels
component: comments component: developer apis help wanted External contributions actively solicited issue: docs Describes missing or incorrect documentation
Milestone
2019_q2_release

Comments

@BeksOmega
Copy link
Collaborator

Expected Behavior

The annotation and the return type match.
A) getAllBlockStyles would return an {Array.<String>} as annotated.
or B) Annotation would say getAllBlockStyles returns {Object.<string, Blockly.BlockStyle>}.

Actual Behavior

The annotation and the return type do not match.

Steps to Reproduce

See here.
@RoboErikG RoboErikG added component: comments component: developer apis help wanted External contributions actively solicited issue: docs Describes missing or incorrect documentation labels Apr 29, 2019
@suhailsinghbains
Copy link

Hi @BeksOmega
Can I please work on this issue, I am new here.
Thanks

@BeksOmega
Copy link
Collaborator Author

Hi @suhailsinghbains
I don't manage the github, I'm just a contributor =) but generally if something is marked with the help wanted tag that means anyone can grab it.
--Beka

@suhailsinghbains
Copy link

I can't find the installation docs, can you please help me how to set up the project locally.
Thanks

@BeksOmega
Copy link
Collaborator Author

You'll want to look at getting the code. That should be enough to get you started with this issue :D

Hopefully that'll get you up and running, but if you have further questions please post on the developer forum. I hope it goes well!
Beka

P.S. If you want to do further work with blockly I'd start by reading through some of the docs and messing with the playground.

NeilFraser added a commit that referenced this issue May 30, 2019
@NeilFraser
Fix 19 warnings in theme-related code.
797f038 
Resolves #2414
@NeilFraser NeilFraser mentioned this issue May 30, 2019
Merged
NeilFraser added a commit that referenced this issue May 30, 2019
@NeilFraser
Fix 19 warnings in theme-related code. (#2523)
dce0b77 
* Fix 19 warnings in theme-related code.

Resolves #2414

* Remove suppressPrefixSuffix property definition

The mixin code throws an error if property exists on both objects.

* eslint has strange ideas about indentation.
@NeilFraser
Copy link
Contributor

Fixed. Thanks @BeksOmega!

@rachel-fenichel rachel-fenichel mentioned this issue Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: comments component: developer apis help wanted External contributions actively solicited issue: docs Describes missing or incorrect documentation
Projects
None yet
Milestone
2019_q2_release
Development

No branches or pull requests
4 participants
@NeilFraser @suhailsinghbains @RoboErikG @BeksOmega