Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace closure toolbox categories with a custom implementation #2735

Closed
RoboErikG opened this issue Jul 29, 2019 · 2 comments
Closed

Replace closure toolbox categories with a custom implementation #2735

RoboErikG opened this issue Jul 29, 2019 · 2 comments
Assignees
@samelhusseini
Labels
component: developer apis internal External contributions not accepted issue: feature request Describes a new feature and why it should be added type: cleanup
Milestone
2019_q3_release

Comments

@RoboErikG
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We've been depending on collapsible lists from the Closure UI library for the toolbox's categories. This is one of the big remaining parts of removing Closure UI from Blockly.

Describe the solution you'd like

Custom toolbox categories with a well defined Blockly API. Should be compatible with existing documented APIs.

Describe alternatives you've considered

Additional context
@RoboErikG RoboErikG added type: cleanup issue: feature request Describes a new feature and why it should be added component: developer apis internal External contributions not accepted labels Jul 29, 2019
@RoboErikG RoboErikG added this to the 2019_q3_release milestone Jul 29, 2019
@samelhusseini
Copy link
Contributor

Consider:

  • Categories that are used as Labels or Buttons with custom callbacks.

@samelhusseini samelhusseini self-assigned this Aug 15, 2019
@samelhusseini
Copy link
Contributor

Resolved by #2819

@rachel-fenichel rachel-fenichel mentioned this issue Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samelhusseini samelhusseini

Labels
component: developer apis internal External contributions not accepted issue: feature request Describes a new feature and why it should be added type: cleanup
Projects
None yet
Milestone
2019_q3_release
Development

No branches or pull requests
2 participants
@RoboErikG @samelhusseini