Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop filtering subdirectories in the compile test script #2838

Closed
rachel-fenichel opened this issue Aug 15, 2019 · 2 comments
Closed

Stop filtering subdirectories in the compile test script #2838

rachel-fenichel opened this issue Aug 15, 2019 · 2 comments
Assignees
@alschmiedt
Labels
component: build process issue: feature request Describes a new feature and why it should be added type: cleanup
Milestone
2019_q3_release

Comments

@rachel-fenichel
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The compile test script (scripts/compile.sh) filters out subdirectories because it was designed to only include one rendering directory.

This doesn't interact well with the new pile of subdirectories in core.

It is also unnecessary now that we've decided to choose the renderer at runtime instead of at compile time.
@rachel-fenichel rachel-fenichel added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Aug 15, 2019
@rachel-fenichel rachel-fenichel mentioned this issue Aug 15, 2019
Merged
3 tasks
@alschmiedt alschmiedt self-assigned this Aug 15, 2019
@rachel-fenichel
Copy link
Collaborator Author

And also in build.py, actually.

@alschmiedt alschmiedt mentioned this issue Aug 16, 2019
Merged
3 tasks
@RoboErikG RoboErikG added component: build process type: cleanup and removed issue: triage Issues awaiting triage by a Blockly team member labels Aug 16, 2019
@RoboErikG RoboErikG added this to the 2019_q3_release milestone Aug 16, 2019
@alschmiedt
Copy link
Contributor

Fixed in #2842

@rachel-fenichel rachel-fenichel mentioned this issue Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alschmiedt alschmiedt

Labels
component: build process issue: feature request Describes a new feature and why it should be added type: cleanup
Projects
None yet
Milestone
2019_q3_release
Development

No branches or pull requests
3 participants
@RoboErikG @rachel-fenichel @alschmiedt