Alignment issues

[NeilFraser]

Old renderer:

Current renderer:

There are three issues:

1. (Blue line) Blocks on the toolbox used to be left-aligned, not counting the tab. This was a deliberate design choice. Now they are aligned including the tab.
2. (Green line) Text on a row used to be straight. Now text height undulates between labels and fields.
3. (Red arrow) The gap between the bottom of a statement block and its enclosing control block used to be zero if there was no "next notch" (indicating that no more blocks could be added), and the height of the "next notch" if there was one (indicating that more blocks could be added). Now there's a huge gap.

I'm also not convinced that the mutator/comment/warning icons ought to be center-aligned on the first row (new behaviour), rather than fixed to the top corner (old behaviour). These icons are block-related, not row-related.

[rachel-fenichel]

1. This is Blocks with outputs misaligned in flyout #2828
2. Text is now center-aligned in a row (everything is center-aligned in a row) instead of absolutely positioned. Text now undulates slightly within a single block but is significantly improved within a multi-block row (and connections will follow soon):
   old:
   new:

We have a couple of options here:

• Undo the vertical centering entirely
• Define a "baseline" property and align on that instead of centering
• Make text input fields (and fields that inherit from them) place their text slightly lower.

3. Yup, this is a bug. Statement input sizing isn't quite right overall at this point.

Block related icons should still be aligned with the text, in my opinion. Fixing them to the corner will mean they'll be misaligned with the text in the row by a variable amount and looks weird.

[RoboErikG]

Relatively fixed. We'll take another look at text baseline alignment later.