Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topRow.populate and bottomRow.populate belong in info #2945

Closed
rachel-fenichel opened this issue Aug 31, 2019 · 0 comments
Closed

topRow.populate and bottomRow.populate belong in info #2945

rachel-fenichel opened this issue Aug 31, 2019 · 0 comments
Assignees
@moniika @rachel-fenichel
Labels
component: rendering issue: bug Describes why the code or behaviour is wrong type: cleanup
Milestone
2019_q3_release

Comments

@rachel-fenichel
Copy link
Collaborator

Everything else is populated in info, and Sam has made a good case for wanting to change what's in those rows by renderer type, which also points at putting population in info.

Argument against: mostly that there's already lots of code there.
@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Aug 31, 2019
@rachel-fenichel rachel-fenichel mentioned this issue Aug 31, 2019
Merged
3 tasks
@rachel-fenichel rachel-fenichel added component: rendering and removed issue: triage Issues awaiting triage by a Blockly team member labels Aug 31, 2019
@rachel-fenichel rachel-fenichel added this to the 2019_q3_release milestone Aug 31, 2019
@rachel-fenichel rachel-fenichel mentioned this issue Sep 4, 2019
Merged
3 tasks
@moniika moniika self-assigned this Sep 16, 2019
@moniika moniika mentioned this issue Sep 20, 2019
Merged
3 tasks
@moniika moniika closed this as completed Sep 20, 2019
@rachel-fenichel rachel-fenichel mentioned this issue Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moniika moniika

@rachel-fenichel rachel-fenichel

Labels
component: rendering issue: bug Describes why the code or behaviour is wrong type: cleanup
Projects
None yet
Milestone
2019_q3_release
Development

No branches or pull requests
3 participants
@moniika @RoboErikG @rachel-fenichel