Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zelos] Dynamic output shapes #2977

Closed
samelhusseini opened this issue Sep 6, 2019 · 1 comment
Closed

[zelos] Dynamic output shapes #2977

samelhusseini opened this issue Sep 6, 2019 · 1 comment
Assignees
Labels
component: rendering issue: feature request Describes a new feature and why it should be added

Comments

@samelhusseini
Copy link
Contributor

Describe the bug

We want to have output shapes that can stretch the entire height of the block. This width of the connection can be static, but for a smooth curve we might also want to make that depend on the height.

Proposal

Use an isDynamic flag on connection shapes to determine whether or not a shape is static or dynamic. Use a function for making a path that takes in a height and returns the appropriate path.
When drawing the shape, check whether the path is a function and if so, call it with the height of the row.

@samelhusseini samelhusseini added component: rendering issue: triage Issues awaiting triage by a Blockly team member labels Sep 6, 2019
@samelhusseini samelhusseini self-assigned this Sep 6, 2019
@samelhusseini samelhusseini added the issue: feature request Describes a new feature and why it should be added label Sep 6, 2019
@moniika moniika added this to the Bug Bash Backlog milestone Sep 9, 2019
@moniika moniika removed the issue: triage Issues awaiting triage by a Blockly team member label Sep 9, 2019
@samelhusseini
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: rendering issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

No branches or pull requests

2 participants