Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught typeError in workspaceCommentRenderSvg #3106

Closed
rachel-fenichel opened this issue Sep 26, 2019 · 0 comments
Closed

Uncaught typeError in workspaceCommentRenderSvg #3106

rachel-fenichel opened this issue Sep 26, 2019 · 0 comments
Assignees
@samelhusseini
Labels
issue: bug Describes why the code or behaviour is wrong
Milestone
2019_q3_release

Comments

@rachel-fenichel
Copy link
Collaborator

Uncompressed blockly is broken in the playground after a rebuild--I suspect one of the recent modularization changes.

To replicate:

  • rebuild
  • open the playground
  • check the console
workspace_comment_render_svg.js:72 Uncaught TypeError: Cannot set property 'getHeightWidth' of undefined
    at workspace_comment_render_svg.js:72
(anonymous) @ workspace_comment_render_svg.js:72

It looks like WorkspaceCommentSvg is no longer being included, but WorkspaceCommentSvg.render is, and it's trying to set things on the prototype of WorkspaceCommentSvg.
@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Sep 26, 2019
@samelhusseini samelhusseini self-assigned this Sep 27, 2019
@samelhusseini samelhusseini removed the issue: triage Issues awaiting triage by a Blockly team member label Sep 27, 2019
@samelhusseini samelhusseini added this to the 2019_q3_release milestone Sep 27, 2019
@samelhusseini samelhusseini mentioned this issue Sep 27, 2019
Merged
3 tasks
@rachel-fenichel rachel-fenichel mentioned this issue Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samelhusseini samelhusseini

Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
2019_q3_release
Development

No branches or pull requests
2 participants
@rachel-fenichel @samelhusseini