Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requires.js #5535

Closed
rachel-fenichel opened this issue Sep 24, 2021 · 0 comments · Fixed by #5718
Closed

Remove requires.js #5535

rachel-fenichel opened this issue Sep 24, 2021 · 0 comments · Fixed by #5718
Assignees
@cpcallen
Labels
type: cleanup
Projects
2021 Q4
Milestone
2021_q4_release

Comments

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Sep 24, 2021 •
edited

Steps:

  • Change buildCompressed in build_tasks.js to use core-blockly.js as an entry point, rather than core-requires.js
  • Verify that everything referenced in requires.js is required and re-exported in blockly.js (manual verification)
    • Ignore the debug renderer, which is now in samples.
  • Delete requires.js
  • Remove declareLegacyNamespace from blockly.js
  • Rebuild and run tests
  • Check the playground and demos (on this repository) for errors
@rachel-fenichel rachel-fenichel added type: cleanup issue: triage Issues awaiting triage by a Blockly team member labels Sep 24, 2021
@rachel-fenichel rachel-fenichel added this to To do in Q3 2021 Cleanup via automation Sep 24, 2021
@rachel-fenichel rachel-fenichel moved this from To do to Required for release in Q3 2021 Cleanup Sep 24, 2021
@alschmiedt alschmiedt mentioned this issue Sep 27, 2021
Closed
3 tasks
@alschmiedt alschmiedt added this to the 2021_q4_release milestone Sep 27, 2021
@alschmiedt alschmiedt moved this from Required for release to Punt in Q3 2021 Cleanup Sep 27, 2021
@alschmiedt alschmiedt removed the issue: triage Issues awaiting triage by a Blockly team member label Sep 27, 2021
@rachel-fenichel rachel-fenichel removed this from Punt in Q3 2021 Cleanup Oct 13, 2021
@rachel-fenichel rachel-fenichel added this to To do in 2021 Q4 via automation Oct 13, 2021
@alschmiedt alschmiedt mentioned this issue Oct 18, 2021
Closed
2021 Q4 automation moved this from To do (P0 and P1) to Done Nov 16, 2021
@alschmiedt alschmiedt reopened this Nov 16, 2021
2021 Q4 automation moved this from Done to In progress Nov 16, 2021
@alschmiedt alschmiedt moved this from In progress to To do (P0 and P1) in 2021 Q4 Nov 16, 2021
@cpcallen cpcallen linked a pull request Nov 18, 2021 that will close this issue
chore: Record renamings for named exports #5719
Merged
3 tasks
@cpcallen cpcallen removed a link to a pull request Nov 18, 2021
chore: Record renamings for named exports #5719
Merged
3 tasks
@cpcallen cpcallen linked a pull request Nov 18, 2021 that will close this issue
chore: Remove core/requires.js #5718
Merged
3 tasks
@cpcallen cpcallen mentioned this issue Nov 18, 2021
Merged
3 tasks
@cpcallen cpcallen self-assigned this Nov 18, 2021
@cpcallen cpcallen closed this as completed Dec 6, 2021
2021 Q4 automation moved this from To do (P0 and P1) to Done Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpcallen cpcallen

Labels
type: cleanup
Projects
No open projects
2021 Q4
Done
Milestone
2021_q4_release
Development

Successfully merging a pull request may close this issue.

chore: Remove core/requires.js cpcallen/blockly
3 participants
@cpcallen @rachel-fenichel @alschmiedt