Propagate the visible state when blocks connect #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
force-pushed
the
roboerikg-connectionHideAll
branch
2 times, most recently
from
79b7dc0
to
fc087ed
Compare
|
This still needs more work. It seems to be working, but there were quite a few edge cases that I had to fix and I don't think I've caught them all. |
|
Four lint errors in |
RoboErikG
force-pushed
the
roboerikg-connectionHideAll
branch
from
fc087ed
to
9263f4e
Compare
AnmAtAnm
reviewed
Aug 23, 2018
|
|
||
|
|
||
| function renderedConnectionTest_setup() { | ||
|
|
There was a problem hiding this comment.
Intending to complete these before merging?
There was a problem hiding this comment.
Yes, I need to write tests still. Probably won't happen for a week or two.
AnmAtAnm
reviewed
Aug 23, 2018
|
|
||
| /** | ||
| * Disconnect this connection. | ||
| */ |
| Blockly.RenderedConnection.prototype.connect = function(otherConnection) { | ||
| Blockly.RenderedConnection.superClass_.connect.call(this, otherConnection); | ||
| // This is a quick check to make sure we aren't doing unecessary work. | ||
| if (this.hidden_ || otherConnection.hidden_) { |
There was a problem hiding this comment.
Is there actually a need to test the inferior connection? I can't think of one, though test both does seem safer.
There was a problem hiding this comment.
It's easier to just check both rather than verify which is the inferior connection.
3 tasks
This fixes google#1967. In rendered connections when connecting: - If the superior connection is hidden this hides the newly connected block. - If the superior connection isn't hidden it makes sure the block is visible. In rendered connections when disconnecting: - If the superior connection is hidden, make the disconnected block stack visible. TODO before review: - write tests. - update collapsed message
RoboErikG
force-pushed
the
roboerikg-connectionHideAll
branch
from
9263f4e
to
b071b4f
Compare
|
Tests added! This PR is now ready to go once there's a final review. |
RoboErikG
force-pushed
the
roboerikg-connectionHideAll
branch
2 times, most recently
from
ea86e22
to
907d312
Compare
rachel-fenichel
approved these changes
Apr 15, 2019
RoboErikG
force-pushed
the
roboerikg-connectionHideAll
branch
from
907d312
to
39e6bf2
Compare
3 tasks
RoboErikG
added a commit
to RoboErikG/blockly
that referenced
this pull request
Jul 19, 2019
This reverts commit ec78eeb.
3 tasks
rachel-fenichel
added a commit
that referenced
this pull request
Jul 20, 2019
Revert changes related to #2003
rachel-fenichel
pushed a commit
that referenced
this pull request
Jul 20, 2019
This reverts commit ec78eeb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1967.
In rendered connections when connecting:
In rendered connections when disconnecting:
TODO before review: write tests.
The basics
The details
Resolves
#1967
Proposed Changes
Adds logic to rendered_connection to hide or unhide blocks when they are connected to a hidden connection.
Reason for Changes
If you programatically connect a block to a hidden connection the block remains visible and gets placed in a random spot. The block should be hidden when connected and unhidden when disconnected.
Test Coverage
Tested on:
Desktop Chrome
Additional Information
This change is