Fix bad xml element when generating next node #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes google#2096 We were creating a text node to wrap any block connected to next when we should have just been attaching the generated dom.
rachel-fenichel
approved these changes
Oct 30, 2018
|
lg, please also make a pull request from the same branch against rc/Oct_18 so it gets into the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2096
We were creating a text node to wrap any block connected to
next when we should have just been attaching the generated dom.
The basics
The details
Resolves
Resolves #2096
Proposed Changes
Reason for Changes
Test Coverage
Tested on:
Desktop Chrome
Additional Information
This change is