Run generator tests on Travis #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
reviewed
Nov 9, 2018
| loadSelected(); | ||
| }) | ||
| }) | ||
| .pause(10000) |
There was a problem hiding this comment.
Are 10 second pauses the only way to make sure this works?
There was a problem hiding this comment.
It shouldn't be. I'll look into it.
tests/scripts/run_generators.sh
Outdated
| local tmp_filename="${TMP_DIR}generated.$suffix" | ||
| if [ ! -f $tmp_filename ]; then | ||
| echo "File $tmp_filename not found!" | ||
| FAILURE_COUNT=$((FAILURE_COUNT+1)) |
There was a problem hiding this comment.
Should this return if the file doesn't exist?
There was a problem hiding this comment.
Changed to do the next steps if the file is found, and otherwise simply report the error.
tests/scripts/run_generators.sh
Outdated
| local golden_filename="${GOLDEN_DIR}generated.$suffix" | ||
| if [ ! -f $golden_filename ]; then | ||
| echo "File $golden_filename not found!" | ||
| FAILURE_COUNT=$((FAILURE_COUNT+1)) |
rachel-fenichel
commented
Nov 9, 2018
tests/scripts/run_generators.sh
Outdated
| local tmp_filename="${TMP_DIR}generated.$suffix" | ||
| if [ ! -f $tmp_filename ]; then | ||
| echo "File $tmp_filename not found!" | ||
| FAILURE_COUNT=$((FAILURE_COUNT+1)) |
There was a problem hiding this comment.
Changed to do the next steps if the file is found, and otherwise simply report the error.
tests/scripts/run_generators.sh
Outdated
| local golden_filename="${GOLDEN_DIR}generated.$suffix" | ||
| if [ ! -f $golden_filename ]; then | ||
| echo "File $golden_filename not found!" | ||
| FAILURE_COUNT=$((FAILURE_COUNT+1)) |
| loadSelected(); | ||
| }) | ||
| }) | ||
| .pause(10000) |
There was a problem hiding this comment.
It shouldn't be. I'll look into it.
RoboErikG
approved these changes
Nov 10, 2018
rachel-fenichel
force-pushed
the
feature/run_gen_tests_in_browser
branch
from
e1299b7
to
b33d832
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Generator tests have not previously been scripted.
Proposed Changes
For each language:
I also updated some of the test names to get rid of name conflicts in functions between text and list test, which were causing some tests to not be run when loading all of the tests with appendDomToWorkspace.
I verified this fix by checking that the same number of tests are run when loading test suites individually and when loading them all together.
Reason for Changes
Generator tests are frustrating.
Test Coverage
Tested by running the run_all_tests script locally. I also ran the golden code for each language and verified that all tests pass. For PHP I removed the known broken generated code (see #1201) and verified that the rest of the generated code works.