Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow statement connections to connect around block stacks during drags #2147

Merged
merged 3 commits into from Nov 30, 2018

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Fixes #2131

Proposed Changes

Allow statement inputs to connect around block stacks during drags.
Remove distinction between first statement connection and other statement connections.

Reason for Changes

See #2131

Test Coverage

Tested with the example in #2131, and with an if-else block to test the case with more than one statement input.

Additional Information

This makes it possible to connect on a statement input, but it's still not a great experience--the insertion marker is a little too stubborn about sticking around, so you have to drag away from the target and then back to switch which of the statement inputs you're connecting to.

@rachel-fenichel
Copy link
Collaborator Author

@alschmiedt fyi

@rachel-fenichel
Copy link
Collaborator Author

Actually, the stickiness was because there was a check in InsertionMarkerManager.shouldUpdatePreviews_ that was checking if the proposed closest connection was the same as the old closest connection, but didn't check if the local connection had changed. Fixed in the third commit.

@rachel-fenichel rachel-fenichel merged commit 3cbb137 into google:develop Nov 30, 2018
@rachel-fenichel rachel-fenichel deleted the bugfix/2131 branch November 30, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants