Reconnects child blocks when an undo is done on an else block #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
approved these changes
Dec 13, 2018
blocks/logic.js
Outdated
| @@ -425,6 +422,30 @@ Blockly.Constants.Logic.CONTROLS_IF_MUTATOR_MIXIN = { | |||
| clauseBlock.nextConnection.targetBlock(); | |||
| } | |||
| }, | |||
| /** | |||
| * Reconstructs the block with all child blocks attached. | |||
| * Fixes issue #2037. | |||
There was a problem hiding this comment.
Don't need this comment about which issue the code fixes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#2037
Proposed Changes
Reconnects the children of an if/else block after an undo is made.
Reason for Changes
Before Undo
After Undo
When a user tries to undo adding an else block it rebuilds the if/else block by removing all inputs and reconstructing with the appropriate number of elseif and else inputs. When removing the inputs it disconnects any statements attached to the inputs.
Test Coverage
Tested on:
Desktop Chrome
Desktop Firefox
Desktop Opera
Additional Information