Disable insertion markers for the December 2018 release #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
No issue, but we want to let insertion markers soak longer in develop before enabling them in master.
Proposed Changes
Revert to using the DraggedConnectionManager instead of the InsertionMarkerManager, but leave the insertion marker code in.
Reason for Changes
This is part of the original plan--we want to test insertion markers longer before enabling them.
Test Coverage
Tested in the playground on Chrome.
Additional information
The changes to blockly_uncompressed are necessary because this PR changes dependencies.