Documentation update #2366
Merged
Documentation update #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -275,6 +275,8 @@ Blockly.Generator.prototype.valueToCode = function(block, name, outerOrder) { | |||
|
|
|||
| /** | |||
| * Generate code representing the statement. Indent the code. | |||
| * This is mainly used in generators. When trying to generate code to evaluate | |||
There was a problem hiding this comment.
In addition, change "Generate code representing the statement." to "Generate a code string representing the blocks attached to the named statement input."
Between the two changes, hopefully we'll reduce confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#2339
Proposed Changes
Update documentation so that we are more clear statementToCode is used in generators.
Reason for Changes
Multiple forum posts showing that people were confused about the usage.
Test Coverage
Tested on:
Additional Information